Merge pull request #486 from httpswift/ci-issues

Fix issues in the CI with Danger

.github/workflows/danger.yml

@@ -1,32 +1,25 @@
 name: Danger
+
 on:
   pull_request:
+    types: [opened, synchronize, edited]
     branches:
-        - stable
+      - stable
 
 jobs:
   Danger:
-    runs-on: macos-latest
+    runs-on: ubuntu-18.04
     steps:
-      - uses: actions/checkout@v2
-      - name: Cache Bundle Dependencies
-        uses: actions/cache@v1
-        with:
-          path: vendor/bundle
-          key: 1-gems-{{ checksum "Gemfile.lock" }}
-          restore-keys: 1-gems-
-      - name: Set Ruby Version
-        uses: actions/setup-ruby@v1
+      - uses: actions/checkout@v1
+
+      - uses: ruby/setup-ruby@v1
         with:
-            ruby-version: 2.6
-      - name: Install Ruby Dependencies
+          ruby-version: 2.6 # Not needed with a .ruby-version file
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      
+      - name: Danger
         run: |
-            bundle config path vendor/bundle
-            bundle check || bundle install
-        env:
-          BUNDLE_JOBS: 4
-          BUNDLE_RETRY: 3
-      - name: Running Danger
-        run: bundle exec danger
+          bundle exec danger --fail-on-errors=true
+        shell: bash
         env:
-          DANGER_GITHUB_API_TOKEN: ${{ secrets.DANGER_GITHUB_API_TOKEN }}
+          DANGER_GITHUB_API_TOKEN: ${{ secrets.BOT_ACCESS_TOKEN }}

.github/workflows/macos-tests.yml

@@ -21,19 +21,19 @@ jobs:
             mkdir -p tmp/test-results/
       - name: Run Unit Test - macOS
         run: |
-            cd XCode
+            cd Xcode
             set -o pipefail && xcodebuild test -scheme SwifterMac -sdk macosx -destination "arch=x86_64" | xcpretty -c -r html --output $TEST_REPORTS/macOS.html
       - name: Run Unit Test - iOS
         run: |
-            cd XCode
+            cd Xcode
             set -o pipefail && xcodebuild test -scheme SwifteriOS -sdk iphonesimulator -destination "name=iPhone 8" | xcpretty -c -r html --output $TEST_REPORTS/iOS.html
       - name: Run Unit Test - tvOS
         run: |
-            cd XCode
+            cd Xcode
             set -o pipefail && xcodebuild test -scheme SwiftertvOS -sdk appletvsimulator -destination "name=Apple TV 4K (at 1080p)" | xcpretty -c -r html --output $TEST_REPORTS/tvOS.html
       - name: Run Unit Test - Swift Package Manager
         run: |
-            cd XCode
+            cd Xcode
             swift build && swift test
       - name: Archive Test results
         uses: actions/upload-artifact@v1

.gitignore

@@ -27,4 +27,4 @@ DerivedData
 
 .build/
 Packages/
-/XCode/.DS_Store
+/Xcode/.DS_Store

.swiftlint.yml

@@ -16,6 +16,6 @@ disabled_rules:
 
 excluded: # paths to ignore during linting. Takes precedence over `included`.
   - LinuxMain.swift
-  - XCode/Tests/XCTestManifests.swift
+  - Xcode/Tests/XCTestManifests.swift
   - Tests/XCTestManifests.swift
   - Package.swift

CHANGELOG.md

@@ -20,7 +20,8 @@ All notable changes to this project will be documented in this file. Changes not
 
 ## Fixed
 
-- Fix misspell `serialise`. ([#473](https://github.com/httpswift/swifter/pull/473)) by [@mtgto](https://github.com/mtgto)
+* Fix misspell `serialise`. ([#473](https://github.com/httpswift/swifter/pull/473)) by [@mtgto](https://github.com/mtgto)
+* Fix an issue causing Danger was not working properly. ([#486](https://github.com/httpswift/swifter/pull/486)) by [@Vkt0r](https://github.com/Vkt0r)
 
 # [1.5.0]
 

Dangerfile

@@ -26,10 +26,10 @@ swiftlint.config_file = '.swiftlint.yml'
 swiftlint.lint_files
 
 # Warn when new tests are added but the XCTestManifests wasn't updated to run on Linux
-tests_added_or_modified = !git.modified_files.grep(/XCode\/Tests/).empty? || !git.added_files.grep(/XCode\/Tests/).empty?
-xc_manifest_updated = !git.modified_files.grep(/XCode\/Tests\/XCTestManifests.swift/).empty?
+tests_added_or_modified = !git.modified_files.grep(/Xcode\/Tests/).empty? || !git.added_files.grep(/Xcode\/Tests/).empty?
+xc_manifest_updated = !git.modified_files.grep(/Xcode\/Tests\/XCTestManifests.swift/).empty?
 if tests_added_or_modified && !xc_manifest_updated
-  warn("It seems like you've added new tests to the library. If that's the case, please update the [XCTestManifests.swift](https://github.com/httpswift/swifter/blob/stable/XCode/Tests/XCTestManifests.swift) file running in your terminal the command `swift test --generate-linuxmain`.")
+  warn("It seems like you've added new tests to the library. If that's the case, please update the [XCTestManifests.swift](https://github.com/httpswift/swifter/blob/stable/Xcode/Tests/XCTestManifests.swift) file running in your terminal the command `swift test --generate-linuxmain`.")
 
   # This is a temporary warning to remove the entry for the failed test until we solve the issue in Linux
   warn("If you ran the command `swift test --generate-linuxmain` in your terminal, please remove the line `testCase(IOSafetyTests.__allTests__IOSafetyTests),` from `public func __allTests() -> [XCTestCaseEntry]` in the bottom of the file. For more reference see [#366](https://github.com/httpswift/swifter/issues/366).")

Gemfile.lock

@@ -11,7 +11,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (8.0.5)
+    danger (8.2.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -23,16 +23,23 @@ GEM
       kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
       octokit (~> 4.7)
-      terminal-table (~> 1)
-    danger-swiftlint (0.24.4)
+      terminal-table (>= 1, < 4)
+    danger-swiftlint (0.26.0)
       danger
       rake (> 10)
       thor (~> 0.19)
-    faraday (1.0.1)
+    faraday (1.4.1)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
       multipart-post (>= 1.2, < 3)
+      ruby2_keywords (>= 0.0.4)
+    faraday-excon (1.1.0)
     faraday-http-cache (2.2.0)
       faraday (>= 0.8)
-    git (1.7.0)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
+    git (1.8.1)
       rchardet (~> 1.8)
     kramdown (2.3.1)
       rexml
@@ -41,18 +48,19 @@ GEM
     multipart-post (2.1.1)
     nap (1.1.0)
     no_proxy_fix (0.1.2)
-    octokit (4.18.0)
+    octokit (4.21.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     public_suffix (4.0.6)
-    rake (13.0.1)
+    rake (13.0.3)
     rchardet (1.8.0)
     rexml (3.2.5)
+    ruby2_keywords (0.0.4)
     sawyer (0.8.2)
       addressable (>= 2.3.5)
       faraday (> 0.8, < 2.0)
-    terminal-table (1.8.0)
+    terminal-table (3.0.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
     thor (0.20.3)
     unicode-display_width (1.7.0)

Package.swift

@@ -16,7 +16,7 @@ let package = Package(
     .target(
       name: "Swifter", 
       dependencies: [], 
-      path: "XCode/Sources"
+      path: "Xcode/Sources"
       ),
 
     .target(
@@ -31,7 +31,7 @@ let package = Package(
       dependencies: [
         "Swifter"
       ], 
-      path: "XCode/Tests"
+      path: "Xcode/Tests"
     )
   ]
 )

README.md

@@ -9,7 +9,7 @@
 Tiny http server engine written in [Swift](https://developer.apple.com/swift/) programming language.
 
 ### Branches
-`* stable` - lands on CocoaPods and others. Supports the latest non-beta XCode and SPM. Stable.
+`* stable` - lands on CocoaPods and others. Supports the latest non-beta Xcode and SPM. Stable.
 
 `* master` - stable branch plus experimental web-framework layer.
 

Swifter.podspec

@@ -10,7 +10,7 @@ Pod::Spec.new do |s|
   s.osx.deployment_target = "10.10"
   s.tvos.deployment_target = "9.0"
   s.source                = { :git => "https://github.com/httpswift/swifter.git", :tag => "1.5.0" }
-  s.source_files          = 'XCode/Sources/*.{swift}'
+  s.source_files          = 'Xcode/Sources/*.{swift}'
   s.swift_version         = '4.2'
 
 end

XCode/LinuxMain.swift → Xcode/LinuxMain.swift

@@ -1,5 +1,4 @@
 import XCTest
-
 import SwifterTests
 
 var tests = [XCTestCaseEntry]()

XCode/Tests/SwifterTestsHttpParser.swift → Xcode/Tests/SwifterTestsHttpParser.swift

@@ -50,7 +50,7 @@ class SwifterTestsHttpParser: XCTestCase {
         }
     }
 
-    // swiftlint:disable function_body_length
+    // swiftlint:disable function_body_length cyclomatic_complexity
     func testParser() {
         let parser = HttpParser()
 

XCode/Tests/SwifterTestsWebSocketSession.swift → Xcode/Tests/SwifterTestsWebSocketSession.swift

@@ -29,7 +29,7 @@ class SwifterTestsWebSocketSession: XCTestCase {
         }
     }
 
-    // swiftlint:disable function_body_length
+    // swiftlint:disable function_body_length cyclomatic_complexity
     func testParser() {
 
         do {